Have you had a chance to review these changes? Please let me know so I know what I should do next with this batch of changes.
Thanks, Ryan On Thu, Jun 23, 2011 at 10:36 PM, Ryan Boggs <rmbo...@gmail.com> wrote: > Updated both the diff in NAnt's patches section and atlassian, just in > case there are issues: > > https://sourceforge.net/tracker/index.php?func=detail&aid=3311661&group_id=31650&atid=402870 > > https://fisheye1.atlassian.com/cru/CR-62 > > I switched the DetermineProductVersion method to use the > "ms:PropertyGroup/ms:TargetFrameworkVersion" xml path since it's > present across all msbuild files. I also added a check with the c++ > pdb file names. > > Thanks, > Ryan > > On Tue, Jun 21, 2011 at 5:36 PM, Ryan Boggs <rmbo...@gmail.com> wrote: >> Hey Dominik, >> >> I saw your notes in the atlassian review and I see your point. It >> would probably make more sense to use the "ToolsVersion" property >> rather than relying on the PropertyGroup/ProductVersion xml node. I >> just took a look at some project files created by Sharpdevelop and >> none of the project files had that xml node but they did have the >> ToolsVersion property. I can give this another run through later this >> week. >> >> Thanks, >> Ryan >> >> On Thu, Jun 16, 2011 at 7:26 PM, Ryan Boggs <rmbo...@gmail.com> wrote: >>> Hi, >>> >>> Updated the patch posted in NAnt's SF patches section. It's the top >>> one in red. Also, it looks like there was some feedback on there for >>> the updates regarding the C++ portion of it. >>> >>> Please see inline for other comments. >>> >>> On Thu, Jun 16, 2011 at 7:13 AM, Martin Aliger <martin_ali...@gordic.cz> >>> wrote: >>>> I just checked and it correctly resolves all the MSBuild providers on my >>>> machine. >>>> Maybe it is becouse I have NAnt.MSBuild.dll in same directory as NAnt.exe? >>>> Maybe plugins do not resolve when in one of those Framework lib which is >>>> default for MSBuild assembly atm (no idea why). Or perhaps the order in >>>> which assemblies are loaded? >>> It's still not on my machine. I moved the assembly to the same dir as >>> the executable. Changed the target framework to net-2.0 and it still >>> does not pick up the plugins. I'm kinda wondering if it is my >>> machine. Am I the only one experiencing this? >>>> >>>> The registration is done in PluginScanner class from Core. All loaded types >>>> should be send into that (via TypeFactory). >>> Thanks, I take a look at this as well. >>>> >>>> Btw: I noticed, the solution providers from MSBuild assembly got VSNet >>>> namespace. Maybe it should be changed, for clarity. >>> I tried switching this too but it didn't make a difference. Unless >>> this is really making a difference, I don't see any reason to change >>> it right now. >>>> >>>> Martin Aliger >>>> >>>> >>>> >>>> -----Original Message----- >>>> From: Ryan Boggs [mailto:rmbo...@gmail.com] >>>> Sent: Thursday, June 16, 2011 3:37 PM >>>> To: Martin Aliger >>>> Cc: Dominik Guder; nant-developers@lists.sourceforge.net >>>> Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild & VSNet Tasks >>>> Importance: Low >>>> >>>> Hi, >>>> >>>> Please see inline. >>>> >>>> Thanks, >>>> Ryan >>>> >>>> On Jun 16, 2011, at 2:39 AM, "Martin Aliger" <martin_ali...@gordic.cz> >>>> wrote: >>>> >>>>>>> Hi Ryan, sln file handling is some kind of broken since VS2005. They >>>>>>> only work with 2002/2003. I would not spend to much time for now in >>>>>>> sln file handling in VS2005 and up. >>>>>> Eww, makes sense. Well, not to let my work go to waste, I think I >>>>>> know why >>>>> it isn't working. The plugins that contains the schema information >>>>> for >>>>> VS2005+ solution files (NAnt.MSBuild.dll) doesn't seem to be getting >>>>> VS2005+ picked >>>>> up during NAnt's plugin >discovery phase. >>>>>> However, I have been having difficulty trying to locate where the >>>>>> plugin >>>>> discovery phase occurs in NAnt to make sure that they are getting picked >>>> up. >>>>> There is also the fact that the VS2005+ solution plugin classes are >>>>> marked as internal but I am not sure >how much of an impact that is making >>>> overall. >>>>> >>>>> Discovery mechanism was made by me and Gert some time ago. I could >>>>> look into it... >>>> Thanks Martin. I thought your names looked familiar. :) >>>>> >>>>> SolutionFactory.cs is main branching thingy. Providers itself are >>>>> registred though Core's IPluginConsumer and ISolutionBuildProvider >>>> interfaces. >>>> I see that and it seems to be working ok with the classes within the >>>> NAnt.VSNet assembly. It just won't pickup the classes from the >>>> NAnt.MSBuild >>>> assembly. If u can point me to where in the code that the solution task >>>> begins to search for plugins in external assemblies, I can research further >>>> as well. >>>>> >>>>> M. >>>>> >>>> >>>> >>> >> > ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
