Hi, Thought I put in such a patch but it looks like I didn't yet. I will see about creating it today.
Thanks, Ryan On Fri, Jul 22, 2011 at 2:54 AM, Martin Aliger <martin_ali...@gordic.cz> wrote: > Yes, your solution is better. Depending on ProjectVersion was throwing odd > exceptions when it was not included (which happens even in VS for whatever > reason): > > > <internalerror> > <type>System.ArgumentException</type> > <message><![CDATA[Version string portion was too short or too > long.]]></message> > <stacktrace><![CDATA[ at > System.Version.VersionResult.SetFailure(ParseFailureKind failure, String > argument) > at System.Version.TryParseVersion(String version, VersionResult& result) > at System.Version.Parse(String input) > at System.Version..ctor(String version) > at NAnt.MSBuild.MSBuildProject.DetermineProductVersion(XmlElement > docElement) > at NAnt.VSNet.ProjectBase..ctor(XmlElement xmlDefinition, SolutionTask > solutionTask, TempFileCollection temporaryFiles, GacCache gacCache, > ReferencesResolver referencesResolver, DirectoryInfo outputDir) > at NAnt.MSBuild.MSBuildProject..ctor(SolutionBase solution, String > projectPath, XmlElement xmlDefinition, SolutionTask solutionTask, > TempFileCollection tfc, GacCache gacCache, ReferencesResolver refResolver, > DirectoryInfo outputDir) > ... > > ToolsVersion should be more accurate as well. I'd need to test it yet, > though. > > Martin Aliger > > -----Original Message----- > From: Ryan Boggs [mailto:rmbo...@gmail.com] > Sent: Wednesday, June 22, 2011 2:36 AM > Subject: Re: [nant-dev] Updates to MSBuild & VSNet Tasks > > Hey Dominik, > > I saw your notes in the atlassian review and I see your point. It would > probably make more sense to use the "ToolsVersion" property rather than > relying on the PropertyGroup/ProductVersion xml node. I just took a look at > some project files created by Sharpdevelop and none of the project files had > that xml node but they did have the ToolsVersion property. I can give this > another run through later this week. > > Thanks, > Ryan > > ------------------------------------------------------------------------------ 10 Tips for Better Web Security Learn 10 ways to better secure your business today. Topics covered include: Web security, SSL, hacker attacks & Denial of Service (DoS), private keys, security Microsoft Exchange, secure Instant Messaging, and much more. http://www.accelacomm.com/jaw/sfnl/114/51426210/ _______________________________________________ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
