On Tue, 10 May 2022 13:35:35 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Daniel's review suggestion - add a test to verify the behaviour of the
>> localAddress() default method implementation on HttpClient.Builder
>> - Daniel's review suggestion - remove reference to "Internet Protocol" in
>> javadoc
>
> test/jdk/java/net/httpclient/HttpClientBuilderTest.java line 268:
>
>> 266: /**
>> 267: * Tests the {@link
>> HttpClient,java.net.http.HttpClient.Builder#localAddress(InetAddress)} method
>> 268: * behaviour when that method is called on a builder returned by
>> {@link HttpClient#newBuilder()}
>
> /**
> * Tests the {@link
> HttpClient,java.net.http.HttpClient.Builder#localAddress(InetAddress)} method
> ```
> This `{@link` looks broken - the `HttpClient,` prefix probably need to be
> removed?
Indeed. That prefix wasn't intentional. I'm not sure how I ended up with that.
I just pushed an update to fix this. Thank you for flagging this.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6690
