This is a request for a code-review of the "Nemo MAC-Type Plugin
Architecture" component of Clearview. I'm setting a timer for comments
that expires on June 2.
The webrev is located here:
http://www.sebweb.net/cr/webrev-mactype/
Hi Seb,
I haven't really reviewed your changes yet. But here are two problems I
found so far:
a. Although it is an existing problem, but I do think the logic in the
aggr_grp_capab_check() is not correct:
1365 if (mac_capab_get(port->lp_mh, MAC_CAPAB_POLL, NULL) !=
1366 grp->lg_gldv3_polling) {
1367 return (B_FALSE);
1368 }
if grp->lg_gldv3_polling is B_FALSE but the port being added has
MAC_CAPAB_POLL capability, this port should be able to be added into the
aggregation.
b. It seems that the format of /etc/aggregation.conf changes after your
work, previous it was like:
"1 L4 2 bge1/0,bge2/0 auto off short"
but now it changes to
"1 L4 2 bge1,bge2 auto off short"
and it might causes error messages like "parsing of configuration
repository failed". Do you need to think of its impact to system upgrade
or bfu?
Thanks
- Cathy
_______________________________________________
networking-discuss mailing list
[email protected]
