Thank you Doug for reviewing the changes.
Doug McCallum wrote:
ifconfig.c: Not a real issue, but a question. Perrdlpi_exit(const
char *cmd, const char *linkname, int err) just does an exit(1). Would
it be useful in
the future to have it return specific error exits to allow possible
error handling based on exit code in the future?
Sorry I may not have understood your question properly, do you mean
returning exit() with 'err' values or returning with DL_SYSERR error
codes?
revarp.c: 125: casts for malloc
Is it necessary to have the cast here? The void pointer returned should
be safe to assign without the cast?
141: since the type of &req would be struct arpreq *,
the addition is going to cause a large pointer
change where you are probably expecting it to be
by size 1.
As I also received comments from Jim, I'll fix this.
-Thanks
Sagun
_______________________________________________
networking-discuss mailing list
[email protected]
