> > There are more offenses here than that. There's no way that > > IFF_POINTOPOINT can be in ipif_flags. It has to be an ill_flags or > > (better still) phyint_flags value because it's a property of the > > underlying interface itself, not a per-logical-interface matter. > > Yes, if we change it so IFF_POINTOPOINT, IFF_BROADCAST are only set > based on the dl_info_ack then it makes sense to move those flags from > the ipif to the ill.
Why not the phyint? BTW, this chane will allow for minor simplifications to a number of functions -- e.g., with Clearview IPMP, the kernel has to iterate over all of the ipifs on an ill to see if IPIF_POINTOPOINT is set (and fail the operation if so) when adding an ill to a group. I look forward to just checking a single flag :-) -- meem _______________________________________________ networking-discuss mailing list [email protected]
