Ok, who's gonna write up a patch. Mark, you did it well the first time :) Just add a way to disable it, and we can land this on master.
On Thu, Feb 9, 2012 at 10:57, Mikeal Rogers <mikeal.rog...@gmail.com> wrote: > Again, this is the *exact* conversation we had about the Host header, down to > the "but i need to remove it for testing". Turned out you really do, because > people's shitty HTTP implementations won't give you the right headers and > you'll need to test that you have sane defaults. > > If we can't learn from our previous mistakes we don't have much of a future :) > > -Mikeal > > On Feb 9, 2012, at February 9, 20121:08 AM, Mark Nottingham wrote: > >> I'm not against a flag to turn it off, but I'm not sure it's really >> necessary. The patch allows you to create the Date yourself (i.e., it won't >> replace or dup it), so the user does have control. >> >> The only use case that isn't met is the ability to send a response without a >> Date. I don't really buy the argument that it's useful for testing, because >> if that were a driving use case for Node, it'd be a LOT different (e.g., >> allowing invalid chunked encoding to be emitted, etc. >> >> Anyway. Like I said, I'm not against a flag, just not sure it's really >> necessary. >> >> As far as a HTTP nanny, we already have one -- http://redbot.org/ >> >> Cheers, >
