dlmarion commented on code in PR #3439:
URL: https://github.com/apache/accumulo/pull/3439#discussion_r1210417415
##########
test/src/main/java/org/apache/accumulo/test/functional/SplitIT.java:
##########
@@ -140,6 +140,8 @@ public void tabletShouldSplit() throws Exception {
VerifyParams params = new VerifyParams(getClientProps(), table, 100_000);
TestIngest.ingest(c, params);
VerifyIngest.verifyIngest(c, params);
+ // ELASTICITY_TODO: Sum of file sizes is zero in
+ // TabletManagementIterator.shouldReturnDueToSplit, so split never
happens
Review Comment:
@keith-turner - this comment is no longer relevant.
`scanner.fetchColumnFamily(DataFileColumnFamily.NAME)` was missing from
`TabletMetadataIterator.tabletShouldSplit`. However, this test is causing some
interesting log messages and the test does not pass. For example in the Manager
log:
```
2023-05-30T14:48:28,283 [manager.TabletGroupWatcher] DEBUG: 1<< may need
splitting.
2023-05-30T14:48:28,283 [manager.TabletGroupWatcher] DEBUG: submitting
tablet 1<< for split
...
2023-05-30T14:48:28,625 [manager.EventCoordinator] INFO : Unassignment
requested 1<<
2023-05-30T14:48:28,630 [fate.Fate] INFO : Seeding FATE[20d8a7db9bc013e4]
System initiated split of tablet 1<< into 23 splits
2023-05-30T14:48:28,632 [manager.Manager] DEBUG: Finished gathering
information from 2 of 2 servers in 0.01 seconds
2023-05-30T14:48:28,667 [split.PreSplit] DEBUG: FATE[20d8a7db9bc013e4]
Failed to set operation id. extent:1<< location:Location
[server=ip-10-113-15-120.evoforge.org:45969[100009be7ac0006], type=CURRENT]
opid:null
2023-05-30T14:48:28,667 [manager.EventCoordinator] INFO : Unassignment
requested 1<<
...
2023-05-30T14:48:28,734 [manager.TabletGroupWatcher] DEBUG: 1<< may need
splitting.
2023-05-30T14:48:28,734 [manager.TabletGroupWatcher] DEBUG: 1<< is not
splittable.
```
and in the TabletServer log:
```
2023-05-30T14:48:40,076 [scan.LookupTask] WARN : exception while doing
multi-scan
java.lang.IllegalStateException: No prev endrow seen. tableId: 1 endrow:
row_00000124�
at
org.apache.accumulo.core.metadata.schema.TabletMetadata.getPrevEndRow(TabletMetadata.java:263)
~[classes/:?]
at
org.apache.accumulo.core.metadata.schema.TabletMetadata.getExtent(TabletMetadata.java:251)
~[classes/:?]
at
org.apache.accumulo.server.manager.state.TabletManagementIterator.shouldReturnDueToLocation(TabletManagementIterator.java:228)
~[classes/:?]
at
org.apache.accumulo.server.manager.state.TabletManagementIterator.computeTabletManagementActions(TabletManagementIterator.java:409)
~[classes/:?]
at
org.apache.accumulo.server.manager.state.TabletManagementIterator.consume(TabletManagementIterator.java:368)
~[classes/:?]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
