keith-turner commented on code in PR #3439:
URL: https://github.com/apache/accumulo/pull/3439#discussion_r1210752090


##########
test/src/main/java/org/apache/accumulo/test/functional/SplitIT.java:
##########
@@ -140,6 +140,8 @@ public void tabletShouldSplit() throws Exception {
       VerifyParams params = new VerifyParams(getClientProps(), table, 100_000);
       TestIngest.ingest(c, params);
       VerifyIngest.verifyIngest(c, params);
+      // ELASTICITY_TODO: Sum of file sizes is zero in
+      // TabletManagementIterator.shouldReturnDueToSplit, so split never 
happens

Review Comment:
   I am looking into this locally.  Added the following to the 
TabletManagementIterator.
   
   ```java
    try {
             computeTabletManagementActions(tm, actions);
           }catch(IllegalStateException ise) {
             LOG.info("decodedRow.size() : {}", decodedRow.size());
             decodedRow.forEach((k2,v2)->LOG.info("{} {}",k2,v2));
             throw ise;
           }
   ```
   
   When there is a failure I am seeing a tablet that only has a future 
location. Still looking into the cause of that.
   
   We may want to add some validation of the TabletManagementIterator.seek() to 
check if all columns or the expected columns are being seeked.  I added some 
debug to see if something was just seeking the future column and that was not 
the case.
   
   I also locally merged the latest elasticity changes into this branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to