dlmarion commented on code in PR #3439:
URL: https://github.com/apache/accumulo/pull/3439#discussion_r1211748798
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -214,8 +214,12 @@ private static Map<TableId,MergeInfo> parseMerges(final
String merges) {
private static boolean shouldReturnDueToSplit(final TabletMetadata tm,
final long splitThreshold) {
- return tm.getFilesMap().values().stream().map(DataFileValue::getSize)
- .collect(Collectors.summarizingLong(Long::longValue)).getSum() >
splitThreshold;
+ final long sumOfFileSizes =
Review Comment:
> So for the location update case it does seem like there is no need to
return it. Merge is going to change a lot, so not sure about it at the moment.
It might need to be returned so that it can be unassigned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
