keith-turner commented on code in PR #3439:
URL: https://github.com/apache/accumulo/pull/3439#discussion_r1210921238
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -214,8 +214,12 @@ private static Map<TableId,MergeInfo> parseMerges(final
String merges) {
private static boolean shouldReturnDueToSplit(final TabletMetadata tm,
final long splitThreshold) {
- return tm.getFilesMap().values().stream().map(DataFileValue::getSize)
- .collect(Collectors.summarizingLong(Long::longValue)).getSum() >
splitThreshold;
+ final long sumOfFileSizes =
Review Comment:
In addition to this check early on in the tserver, I added a check that is
as late as possible in the manager. I added that in
c8d39de73d7984a490c3693aa9760c96546b1bb2 w/o doing a PR. Its such a small
change and this PR does not modify that file. Let me know if you see any
problems w/ that little change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
