dlmarion commented on code in PR #3439:
URL: https://github.com/apache/accumulo/pull/3439#discussion_r1211768892
##########
server/manager/src/test/java/org/apache/accumulo/manager/split/SplitterTest.java:
##########
@@ -65,23 +65,23 @@ public void testShouldInspect() {
expect(tabletMeta2.getExtent()).andReturn(ke2).anyTimes();
replay(tabletMeta2);
- assertTrue(splitter.shouldInspect(tabletMeta1));
Review Comment:
Addressed in cfced0b
##########
server/manager/src/main/java/org/apache/accumulo/manager/split/Splitter.java:
##########
@@ -197,6 +182,10 @@ public boolean shouldInspect(TabletMetadata tablet) {
if (hashCode != null) {
if (hashCode.equals(caclulateFilesHash(tablet))) {
return false;
+ } else {
+ // We know that the list of files for this tablet have changed
+ // so we can remove it from the set of unsplittable tablets.
+ unsplittable.invalidate(tablet.getExtent());
Review Comment:
Addressed in cfced0b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
