dlmarion commented on PR #4746: URL: https://github.com/apache/accumulo/pull/4746#issuecomment-2243512124
> It looks like since derivation is skipped for the null case, then the previous computed result will continue to get used. That doesn't seem right to me. If the derivation results in null, wouldn't that mean that some configuration changed that invalidated the previously computed result? Shouldn't the deriver itself be updated to compute the default instance as the new value in the null case and cache the null result? If the configuration is updated, and the property type is a class name, then null causes an error. The Deriver interface does not include enough information to know whether or not a null return type is valid, or might cause an error. In the case of the two properties in TableConfiguration, a null value here will cause an error because a class name is expected. The API documentation says, "When configuration is not changing, keeps returning the same object." Maybe the javadoc should be updated to say something about null values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
