dlmarion commented on PR #4746: URL: https://github.com/apache/accumulo/pull/4746#issuecomment-2243777661
> > Maybe the javadoc should be updated to say something about null values. > > Do you think it would make sense to have the javadoc mention that null return values are not expected and make the impl throw an exception if one is seen (could throw an exception instead of log a warn)? This would solve the problem mentioned that can not differentiate between null because of an error or an expected null. I had the changes in 6f1303b staged before I read your comment. So I pushed them, but can change them if you like. I just made a note in the javadoc that if the converter returns null the previous value is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
