dlmarion commented on PR #4746: URL: https://github.com/apache/accumulo/pull/4746#issuecomment-2245575274
I think given the comments above regarding classloader configuration changes, I'm going to change this PR to *not* return the prior property value (in this case a class) and instead throw an error. By returning the prior class value and silently succeeding we are giving the impression that we are doing the correct thing that the user intended, but in reality we are not. Specifically for classes that are used for iterators and such this could lead to incorrect results or unintended consequences. It's likely safer and more correct to just fail. If the Deriver had more information about the type of object that the converter function was going to return, then we might be able to do some validation in the Deriver code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
