keith-turner commented on code in PR #4746:
URL: https://github.com/apache/accumulo/pull/4746#discussion_r1687259222
##########
core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java:
##########
@@ -512,6 +512,12 @@ public T derive() {
if (rc == null || rc.count != uc) {
T newObj = converter.apply(AccumuloConfiguration.this);
+ if (newObj == null) {
+ // The converter should not return a null value, if it does then
+ // use the previous value.
+ return rc.obj;
Review Comment:
`rc` could be null here causing an NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
