ctubbsii commented on code in PR #5785:
URL: https://github.com/apache/accumulo/pull/5785#discussion_r2353225677
##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -572,4 +572,10 @@ private void waitForDeadResCleanerShutdown(long start,
long timeout, TimeUnit ti
}
}
}
+
+ @Override
+ @SuppressWarnings("deprecation")
+ public final void finalize() {
+ // Prevent finalizer attacks (SpotBugs CT_CONSTRUCTOR_THROW)
+ }
Review Comment:
> Do you think that sounds good or would do you think its best to suppress
this at module/project level?
I think trying those 3 fixes, in that order, are probably best. There may be
good reasons to suppress at the module/project level, but it should be a very
good reason. We have relatively few module/project-wide exceptions, and they
are easily articulable, like the comments in the existing
`spotbugs/exclude-filter.xml` files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
