ctubbsii commented on code in PR #5785:
URL: https://github.com/apache/accumulo/pull/5785#discussion_r2353237776
##########
core/pom.xml:
##########
@@ -242,6 +242,13 @@
</plugins>
</pluginManagement>
<plugins>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <configuration>
+ <omitVisitors>SharedVariableAtomicityDetector</omitVisitors>
Review Comment:
It's only temporary while it's in the PR. Once it gets merged, it's more or
less permanent, or at least as permanent as the exclude-filter.xml files. My
review comments are based on the desired end result after this is merged. That
is to say, doing it in a different way while you're working on it is fine...
but unless there's a good reason to have these configured separately from
what's in the exclude-filter.xml files, then it's better that the end result by
the time this is merged, has removed these extra configs, or consolidated them
with the exclude-filter.xml files, so we don't have config scattered everywhere
that basically does similar things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
