ctubbsii commented on code in PR #5785:
URL: https://github.com/apache/accumulo/pull/5785#discussion_r2353207369
##########
hadoop-mapreduce/pom.xml:
##########
@@ -84,6 +84,13 @@
</dependencies>
<build>
<plugins>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <configuration>
+
<omitVisitors>SharedVariableAtomicityDetector,ConstructorThrow</omitVisitors>
Review Comment:
I mean, having the config here raises the question "why are we skipping
these checks?" without bothering to provide an answer. In the other places,
such as the annotation, or the XML file, we generally offer an explanation, but
there isn't one here. It's not clear what checks are being skipped, and why,
when these visitors are being omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
