DomGarguilo commented on code in PR #5785: URL: https://github.com/apache/accumulo/pull/5785#discussion_r2547132907
########## core/src/main/java/org/apache/accumulo/core/iteratorsImpl/conf/ColumnSet.java: ########## @@ -30,6 +30,10 @@ import org.apache.accumulo.core.util.Pair; import org.apache.hadoop.io.Text; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + +@SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", + justification = "Constructor validation is required for proper initialization") Review Comment: I went ahead and made `iteratorsImpl/conf/ColumnSet.java` final. Looked through for more classes that are in this bucket. Found and made final: clientImpl/OfflineIterator.java clientImpl/bulk/LoadMappingIterator.java dataImpl/KeyExtent.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
