dlmarion commented on code in PR #50:
URL:
https://github.com/apache/accumulo-classloaders/pull/50#discussion_r2709417288
##########
modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/LocalCachingContextClassLoaderFactory.java:
##########
@@ -124,7 +152,7 @@ public class LocalCachingContextClassLoaderFactory
implements ContextClassLoader
private void monitorContext(final String contextLocation, long interval) {
LOG.trace("Monitoring context definition file {} for changes at {} second
intervals",
contextLocation, interval);
- EXECUTOR.schedule(() -> checkMonitoredLocation(contextLocation, interval),
interval,
+ executor.schedule(() -> checkMonitoredLocation(contextLocation, interval),
interval,
Review Comment:
I modified your test above to retain the ScheduledFuture and test it. It
does in fact throw an ExecutionException when an ISE or Error is thrown from
the Runnable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
