keith-turner commented on code in PR #50:
URL:
https://github.com/apache/accumulo-classloaders/pull/50#discussion_r2709703141
##########
modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/LocalCachingContextClassLoaderFactory.java:
##########
@@ -312,4 +349,17 @@ public static Map<String,List<String>>
getReferencedFiles() {
return referencedContexts;
}
+ private void handleUncaughtExceptionInMonitor() {
+ cleanupLock.writeLock().lock();
+ try {
Review Comment:
> Ok, we are not scheduling at a fixed rate, just calling schedule at the
end of the task in a finally method. If we moved it out of the finally method
such that it was only rescheduled on success or a handled exception, that that
should be sufficient?
That sounds good, but how will it get rescheduled eventually? Should we
also remove a key from the contextDefs map in the case where its not
rescheduled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
