keith-turner commented on code in PR #50:
URL:
https://github.com/apache/accumulo-classloaders/pull/50#discussion_r2709590494
##########
modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/LocalCachingContextClassLoaderFactory.java:
##########
@@ -152,8 +134,14 @@ public LocalCachingContextClassLoaderFactory() {
private void monitorContext(final String contextLocation, long interval) {
LOG.trace("Monitoring context definition file {} for changes at {} second
intervals",
contextLocation, interval);
- executor.schedule(() -> checkMonitoredLocation(contextLocation, interval),
interval,
- TimeUnit.SECONDS);
+ executor.schedule(() -> {
+ try {
+ checkMonitoredLocation(contextLocation, interval);
+ } catch (Throwable t) {
+ handleExceptionInMonitor();
Review Comment:
Should probably log the exception, seems like whatever is thrown from here
will be discarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
