keith-turner commented on code in PR #50:
URL:
https://github.com/apache/accumulo-classloaders/pull/50#discussion_r2709454229
##########
modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/LocalCachingContextClassLoaderFactory.java:
##########
@@ -312,4 +349,17 @@ public static Map<String,List<String>>
getReferencedFiles() {
return referencedContexts;
}
+ private void handleUncaughtExceptionInMonitor() {
+ cleanupLock.writeLock().lock();
+ try {
Review Comment:
This code may not actually cancel everything. When a scheduled task is
running it may not be on the queue, task may re add their self to the queue
after running.
If all the futures were tracked, could cancel things that way by canceling
the futures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
