Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/29#discussion_r40152076
--- Diff: src/couch_mrview_http.erl ---
@@ -433,6 +443,7 @@ parse_params(Props, Keys) ->
parse_params(Props, Keys, #mrargs{}=Args0) ->
Args = Args0#mrargs{keys=Keys},
+ [check_compatible(K1, K2, Props) || {K1, K2} <- [{"group",
"group_level"}]],
--- End diff --
For current `parse_params` implementation, it's better to have such check
there. Otherwise we have two places that validates params. Also, these params
are not incompatible, but just overlapping: they both sets the same record
field, but with different values. Like if you pass
`group_level=1&group_level=2`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
