Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/29#discussion_r40304612
--- Diff: src/couch_mrview_http.erl ---
@@ -433,6 +443,7 @@ parse_params(Props, Keys) ->
parse_params(Props, Keys, #mrargs{}=Args0) ->
Args = Args0#mrargs{keys=Keys},
+ [check_compatible(K1, K2, Props) || {K1, K2} <- [{"group",
"group_level"}]],
--- End diff --
yeah, I would rather see the the validation happen further down, compare
with how we parse the 'stale' param, we match the allowed values, and throw for
anything else. In this case, we'd throw in the <<"group">> and
<<"group_level">> clause if Args#mrargs.group_level /= undefined.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
