Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/29#discussion_r40306388
--- Diff: src/couch_mrview_http.erl ---
@@ -433,6 +443,7 @@ parse_params(Props, Keys) ->
parse_params(Props, Keys, #mrargs{}=Args0) ->
Args = Args0#mrargs{keys=Keys},
+ [check_compatible(K1, K2, Props) || {K1, K2} <- [{"group",
"group_level"}]],
--- End diff --
@rnewson hm...that could be a problem or will make
`group=false&group_level=0` a valid case.
Seems like we indeed need something `before_parse_params` that checks for
such collisions. Also, there we can ensure, that every parameter was specified
only once. Or we can extend `parse_params` to let it have access to params list
and keep all the validation within the single place. Not sure which one is
better. Tend to the first.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
