Github user nickva commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/29#discussion_r40223588
  
    --- Diff: src/couch_mrview_http.erl ---
    @@ -424,6 +424,16 @@ row_to_json(Id0, Row) ->
         ?JSON_ENCODE(Obj).
     
     
    +check_compatible(K1, K2, Props) ->
    +    case {lists:keymember(K1, 1, Props), lists:keymember(K2, 1, Props)} of
    +        {true, true} ->
    +            Err = ["`", K1, "` and `", K2,"` are incompatible"],
    --- End diff --
    
    @eiri, agreed. io_lib:format would be better and more consistent with other 
error messages in that code. Will update the pr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to