matrei commented on code in PR #14953: URL: https://github.com/apache/grails-core/pull/14953#discussion_r2259260144
########## grails-micronaut/build.gradle: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + id 'groovy' + id 'java-library' + id 'project-report' +} + +version = projectVersion +group = 'org.apache.grails' + +dependencies { + annotationProcessor platform(project(':grails-bom')) + annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + annotationProcessor 'io.micronaut:micronaut-inject-java' + annotationProcessor 'jakarta.annotation:jakarta.annotation-api' + + compileOnlyApi platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + compileOnlyApi 'io.micronaut:micronaut-inject-groovy' + compileOnlyApi 'io.micronaut:micronaut-inject-java' + + api platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + api 'io.micronaut.spring:micronaut-spring-boot-starter' + api "io.micronaut.spring:micronaut-spring-context", { + // required to load the micronaut environment with plugin configuration + exclude group: "org.slf4j", module: "slf4j-simple" Review Comment: Is `slf4j-simple` a dependency brought in by `micronaut-spring-context`? ########## grails-micronaut/build.gradle: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + id 'groovy' + id 'java-library' + id 'project-report' +} + +version = projectVersion +group = 'org.apache.grails' + +dependencies { + annotationProcessor platform(project(':grails-bom')) + annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + annotationProcessor 'io.micronaut:micronaut-inject-java' + annotationProcessor 'jakarta.annotation:jakarta.annotation-api' + + compileOnlyApi platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + compileOnlyApi 'io.micronaut:micronaut-inject-groovy' + compileOnlyApi 'io.micronaut:micronaut-inject-java' + + api platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + api 'io.micronaut.spring:micronaut-spring-boot-starter' + api "io.micronaut.spring:micronaut-spring-context", { Review Comment: Align on single quotes for strings? ########## grails-micronaut/build.gradle: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + id 'groovy' + id 'java-library' + id 'project-report' +} + +version = projectVersion +group = 'org.apache.grails' + +dependencies { + annotationProcessor platform(project(':grails-bom')) + annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + annotationProcessor 'io.micronaut:micronaut-inject-java' + annotationProcessor 'jakarta.annotation:jakarta.annotation-api' + + compileOnlyApi platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + compileOnlyApi 'io.micronaut:micronaut-inject-groovy' + compileOnlyApi 'io.micronaut:micronaut-inject-java' + + api platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + api 'io.micronaut.spring:micronaut-spring-boot-starter' + api "io.micronaut.spring:micronaut-spring-context", { + // required to load the micronaut environment with plugin configuration + exclude group: "org.slf4j", module: "slf4j-simple" + } + api "io.micronaut.cache:micronaut-cache-core", { + exclude group:"org.slf4j", module: "slf4j-simple" + } + + compileOnly platform(project(':grails-bom')) + compileOnly project(':grails-core') + + // Logging + compileOnly 'org.slf4j:slf4j-api' + compileOnly 'org.slf4j:jcl-over-slf4j' + + // Testing + testImplementation platform(project(':grails-bom')) + testImplementation 'org.slf4j:slf4j-simple' + testImplementation('org.spockframework:spock-core') { transitive = false } + + // Required by Spock's Mocking + testRuntimeOnly 'net.bytebuddy:byte-buddy' + testImplementation 'org.objenesis:objenesis' +} + +apply { + // java-configuration must be applied first since tasks are now lazy registered + from rootProject.layout.projectDirectory.file('gradle/java-config.gradle') + from rootProject.layout.projectDirectory.file('gradle/docs-config.gradle') + from rootProject.layout.projectDirectory.file('gradle/publish-config.gradle') + from rootProject.layout.projectDirectory.file('gradle/test-config.gradle') Review Comment: Are there any tests in this project? ########## grails-micronaut/build.gradle: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + id 'groovy' + id 'java-library' + id 'project-report' +} + +version = projectVersion +group = 'org.apache.grails' + +dependencies { + annotationProcessor platform(project(':grails-bom')) + annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + annotationProcessor 'io.micronaut:micronaut-inject-java' + annotationProcessor 'jakarta.annotation:jakarta.annotation-api' + + compileOnlyApi platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + compileOnlyApi 'io.micronaut:micronaut-inject-groovy' + compileOnlyApi 'io.micronaut:micronaut-inject-java' + + api platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + api 'io.micronaut.spring:micronaut-spring-boot-starter' + api "io.micronaut.spring:micronaut-spring-context", { + // required to load the micronaut environment with plugin configuration + exclude group: "org.slf4j", module: "slf4j-simple" + } + api "io.micronaut.cache:micronaut-cache-core", { + exclude group:"org.slf4j", module: "slf4j-simple" + } + + compileOnly platform(project(':grails-bom')) + compileOnly project(':grails-core') + + // Logging + compileOnly 'org.slf4j:slf4j-api' + compileOnly 'org.slf4j:jcl-over-slf4j' + + // Testing + testImplementation platform(project(':grails-bom')) + testImplementation 'org.slf4j:slf4j-simple' + testImplementation('org.spockframework:spock-core') { transitive = false } + + // Required by Spock's Mocking + testRuntimeOnly 'net.bytebuddy:byte-buddy' + testImplementation 'org.objenesis:objenesis' Review Comment: Are there any tests in this project? ########## grails-micronaut/build.gradle: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + id 'groovy' + id 'java-library' + id 'project-report' +} + +version = projectVersion +group = 'org.apache.grails' + +dependencies { + annotationProcessor platform(project(':grails-bom')) + annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + annotationProcessor 'io.micronaut:micronaut-inject-java' + annotationProcessor 'jakarta.annotation:jakarta.annotation-api' + + compileOnlyApi platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + compileOnlyApi 'io.micronaut:micronaut-inject-groovy' + compileOnlyApi 'io.micronaut:micronaut-inject-java' + + api platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + api 'io.micronaut.spring:micronaut-spring-boot-starter' + api "io.micronaut.spring:micronaut-spring-context", { + // required to load the micronaut environment with plugin configuration + exclude group: "org.slf4j", module: "slf4j-simple" + } + api "io.micronaut.cache:micronaut-cache-core", { Review Comment: Align on single quotes for strings? ########## grails-test-examples/micronaut/src/integration-test/groovy/micronaut/BeanInjectionServiceSpec.groovy: ########## @@ -49,9 +49,9 @@ class BeanInjectionServiceSpec extends Specification { service != null } - void "test there are two beans for a Grails service when we inject Micronaut bean in it"() { + void "test there are 1 bean for a Grails service when we inject Micronaut bean in it"() { expect: bInjectService != null - bInjectService.size() == 2 + bInjectService.size() == 1 } Review Comment: Interesting that this has changed! I wonder why there where two beans in this list previously? ########## gradle/publish-root-config.gradle: ########## @@ -65,6 +65,7 @@ def publishedProjects = [ 'grails-interceptors', 'grails-logging', 'grails-mimetypes', + 'grails-micronaut', Review Comment: This list has over time become unsorted. ########## grails-micronaut/build.gradle: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + id 'groovy' + id 'java-library' + id 'project-report' +} + +version = projectVersion +group = 'org.apache.grails' + +dependencies { + annotationProcessor platform(project(':grails-bom')) + annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + annotationProcessor 'io.micronaut:micronaut-inject-java' + annotationProcessor 'jakarta.annotation:jakarta.annotation-api' + + compileOnlyApi platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + compileOnlyApi 'io.micronaut:micronaut-inject-groovy' + compileOnlyApi 'io.micronaut:micronaut-inject-java' + + api platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + api 'io.micronaut.spring:micronaut-spring-boot-starter' + api "io.micronaut.spring:micronaut-spring-context", { + // required to load the micronaut environment with plugin configuration + exclude group: "org.slf4j", module: "slf4j-simple" + } + api "io.micronaut.cache:micronaut-cache-core", { + exclude group:"org.slf4j", module: "slf4j-simple" Review Comment: Is `slf4j-simple` a dependency brought in by `micronaut-cache-core`? ########## grails-micronaut/build.gradle: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + id 'groovy' + id 'java-library' + id 'project-report' +} + +version = projectVersion +group = 'org.apache.grails' + +dependencies { + annotationProcessor platform(project(':grails-bom')) + annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + annotationProcessor 'io.micronaut:micronaut-inject-java' + annotationProcessor 'jakarta.annotation:jakarta.annotation-api' + + compileOnlyApi platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + compileOnlyApi 'io.micronaut:micronaut-inject-groovy' + compileOnlyApi 'io.micronaut:micronaut-inject-java' + + api platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion") + api 'io.micronaut.spring:micronaut-spring-boot-starter' + api "io.micronaut.spring:micronaut-spring-context", { + // required to load the micronaut environment with plugin configuration + exclude group: "org.slf4j", module: "slf4j-simple" + } + api "io.micronaut.cache:micronaut-cache-core", { + exclude group:"org.slf4j", module: "slf4j-simple" + } + + compileOnly platform(project(':grails-bom')) + compileOnly project(':grails-core') + + // Logging + compileOnly 'org.slf4j:slf4j-api' + compileOnly 'org.slf4j:jcl-over-slf4j' Review Comment: Are these dependencies used in this project? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
