sdelamo commented on code in PR #14953:
URL: https://github.com/apache/grails-core/pull/14953#discussion_r2259508395
##########
grails-micronaut/build.gradle:
##########
@@ -0,0 +1,72 @@
+/*
Review Comment:
I think this build file could be simplified to:
```
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
plugins {
id 'groovy'
id 'java-library'
id 'project-report'
}
version = projectVersion
group = 'org.apache.grails'
dependencies {
compileOnlyApi
platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion")
compileOnlyApi 'io.micronaut:micronaut-inject-groovy'
compileOnlyApi 'io.micronaut:micronaut-inject-java'
api
platform("io.micronaut.platform:micronaut-platform:$micronautPlatformVersion")
api 'io.micronaut.spring:micronaut-spring-boot-starter'
compileOnly platform(project(':grails-bom'))
compileOnly project(':grails-core')
}
apply {
// java-configuration must be applied first since tasks are now lazy
registered
from
rootProject.layout.projectDirectory.file('gradle/java-config.gradle')
from
rootProject.layout.projectDirectory.file('gradle/docs-config.gradle')
from
rootProject.layout.projectDirectory.file('gradle/publish-config.gradle')
from
rootProject.layout.projectDirectory.file('gradle/test-config.gradle')
}
```
There are not tests to this project. Thus, I don't think we can trust the
functionality added by the Micronaut Grails plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
