sanjana2505006 commented on code in PR #15584:
URL: https://github.com/apache/grails-core/pull/15584#discussion_r3105773627
##########
.github/scripts/releaseDistributions.sh:
##########
@@ -61,9 +61,14 @@ svn_exists() {
old_release_folder="$(svn ls "${svn_flags[@]}" "${RELEASE_ROOT}" | awk -F/
'NF{print $1; exit}')"
Review Comment:
Using `awk ... exit` only identifies the first folder in the SVN directory.
In a multi-branch environment (e.g., having both 6.x and 7.x releases in the
same folder), this might prompt to delete a folder from a different branch
while missing the actual previous version of the current branch.
I guess it would be safer to loop through all folders found by `svn ls` and
prompt for each?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
