sanjana2505006 commented on code in PR #15584:
URL: https://github.com/apache/grails-core/pull/15584#discussion_r3105774967
##########
.github/scripts/releaseDistributions.sh:
##########
@@ -61,9 +61,14 @@ svn_exists() {
old_release_folder="$(svn ls "${svn_flags[@]}" "${RELEASE_ROOT}" | awk -F/
'NF{print $1; exit}')"
if [[ -n "${old_release_folder}" ]]; then
PRIOR_RELEASE_URL="${RELEASE_ROOT}/${old_release_folder}"
- echo "🗑️ Deleting old release folder: ${PRIOR_RELEASE_URL}"
- svn rm "${svn_flags[@]}" -m "Remove previous release ${old_release_folder}"
"${PRIOR_RELEASE_URL}"
- echo "✅ Deleted old release folder"
+ read -r -p "Remove old release folder '${old_release_folder}' at
${PRIOR_RELEASE_URL}? [y/N] " confirm
+ if [[ "${confirm}" =~ ^[Yy]$ ]]; then
Review Comment:
Minor suggestion: The regex `^[Yy]$` is quite strict. It might be more
user-friendly to support `yes` as well by using something like `[[ "${confirm}"
=~ ^[Yy](es)?$ ]]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
