borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3440101206
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/RangeQuerySpec.groovy:
##########
@@ -50,7 +54,8 @@ class RangeQuerySpec extends GrailsDataTckSpec {
results.size() == 2
}
- void 'Test between query'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/RangeQuerySpec.groovy:
##########
@@ -78,7 +83,8 @@ class RangeQuerySpec extends GrailsDataTckSpec {
4 == results.size()
}
- void 'Test greater than or equal to and less than or equal to queries'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/PagedResultSpec.groovy:
##########
@@ -18,12 +18,17 @@
*/
package org.apache.grails.data.testing.tck.tests
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.apache.grails.data.testing.tck.domains.Person
+import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
[email protected]({ System.getProperty('hibernate5.gorm.suite') == 'true'
|| System.getProperty('mongodb.gorm.suite') == 'true' ||
System.getProperty('core.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/PersistenceEventListenerSpec.groovy:
##########
@@ -83,6 +83,7 @@ class PersistenceEventListenerSpec extends GrailsDataTckSpec {
listener.events[-2] instanceof PreDeleteEvent
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/PersistenceEventListenerSpec.groovy:
##########
@@ -195,6 +196,7 @@ class PersistenceEventListenerSpec extends
GrailsDataTckSpec {
1 == listener.PostLoadCount
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/ListOrderByHungarianNotationSpec.groovy:
##########
@@ -27,9 +27,10 @@ import
org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
*/
class ListOrderByHungarianNotationSpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
void setupSpec() {
- manager.domainClasses.addAll([ClassWithHungarianNotation])
+ manager.addAllDomainClasses([ClassWithHungarianNotation])
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/EmbeddedPropertyQuerySpec.groovy:
##########
@@ -95,6 +115,9 @@ class EmbeddedPropertyQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManag
book != null
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/EmbeddedPropertyQuerySpec.groovy:
##########
@@ -82,6 +99,9 @@ class EmbeddedPropertyQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManag
book != null
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/EmbeddedPropertyQuerySpec.groovy:
##########
@@ -71,6 +85,9 @@ class EmbeddedPropertyQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManag
book != null
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/EmbeddedPropertyQuerySpec.groovy:
##########
@@ -60,6 +71,9 @@ class EmbeddedPropertyQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManag
book != null
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/EmbeddedPropertyQuerySpec.groovy:
##########
@@ -49,6 +57,9 @@ class EmbeddedPropertyQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManag
book != null
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/EmbeddedPropertyQuerySpec.groovy:
##########
@@ -38,6 +43,9 @@ class EmbeddedPropertyQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManag
book != null
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/EmbeddedPropertyQuerySpec.groovy:
##########
@@ -18,15 +18,20 @@
*/
package org.grails.datastore.gorm
+import spock.lang.Requires
+
import grails.persistence.Entity
import org.apache.grails.data.simple.core.GrailsDataCoreTckManager
import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
class EmbeddedPropertyQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
void setupSpec() {
- manager.domainClasses += [Book2, Author2]
+ manager.addAllDomainClasses([Book2, Author2])
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/DistinctProjectionSpec.groovy:
##########
@@ -24,6 +24,7 @@ import
org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
class DistinctProjectionSpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
