borinquenkid commented on PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#issuecomment-4748540982
## Batch status update on open review threads
Posting a single summary to avoid per-thread notification noise. Here is the
current status of each open comment category:
---
### ✅ Already addressed — `@Requires` regression comments (~45 threads)
All `@Requires` annotations added to TCK and `grails-datamapping-core-test`
specs were reverted in cleanup commits earlier in this branch. The affected
specs (`RangeQuerySpec`, `NegationSpec`, `InheritanceSpec`, `ListOrderBySpec`,
`GormEnhancerSpec`, `FindByMethodSpec`, `EnumSpec`, `DomainEventsSpec`,
`PersistenceEventListenerSpec`, `OrderBySpec`, `PagedResultSpec`,
`NotLikeSpec`, `NotNullQuerySpec`, `ListOrderByHungarianNotationSpec`,
`EmbeddedPropertyQuerySpec`, etc.) all run without any `@Requires` restriction
in the current branch.
### ✅ Already addressed — empty-map `[:]` in `executeUpdate` (~10 threads)
All `executeUpdate('…', [:])` calls were cleaned up. The empty
named-parameter map is no longer passed anywhere in the branch.
### ✅ Already addressed — AI artefact files (`AGENTS.md`, `ISSUES.md`,
`plans/`) (~4 threads)
`grails-data-hibernate7/AGENTS.md`, `grails-data-hibernate7/ISSUES.md`, and
`plans/aggregate-style-violations.md` were all removed in earlier cleanup
commits. `node_modules/**` was moved from the RAT exclusions to `.gitignore`.
### ✅ Already addressed — stale intermediate-commit comments (~15 threads)
Several comments reference an intermediate state of the PR (double license
header in `README.md`, `HibernateGormDatastoreSpec.groovy` typo,
`HibernateDatastoreSpringInitializer.groovy` return removal,
`simplelogger.properties` logging levels, `SchemaMultiTenantSpec`,
`SingleTenantSpec`, `MultiTenancyBidirectionalManyToManySpec`,
`MultiTenancyUnidirectionalOneToManySpec`, `PartitionedMultiTenancySpec`,
`SchemaPerTenantSpec`, `BookController.groovy` params binding). None of these
files have changes in the current branch diff.
---
### ⏳ Awaiting reviewer decision — build-logic / Gradle design (~5 threads)
These require architectural input before we can act:
- `CompilePlugin.groovy` — why `abstractCompile` changes are needed
- `GrailsTestPlugin.groovy` / `GrailsCodeStylePlugin.groovy` — Gradle
built-in aggregation vs. current approach; codestyle plugin separation vote
- `build.gradle` — environment variable override vs. explicit property
- `gradle/test-config.gradle` — shared property plugin approach
### ⏳ Awaiting reviewer decision — design discussions (~5 threads)
- `CriteriaMethods.java:24` — criteria builder extensibility approach
- `GrailsHibernateTemplate.java` — rediff H5 vs H7 removed methods
- `GroovyPagesServlet.java:120` — waiting on @davydotcom
- `Query.java:633` — bad merge question (@borinquenkid)
- `grails-test-examples/hibernate7/grails-hibernate/build.gradle` — TODO
from @jdaugherty
### ⏳ Deferred to follow-on work
- `UniqueConstraintHibernateSpec.groovy:37` — `@DatabaseCleanup` /
transaction-per-test rework
- `HibernateDirtyCheckingSpec.groovy` — force `markDirty` is a known bug
(separate issue)
- `OptimisticLockingSpec.groovy` / MongoDB `@Requires` — TCK vs
hibernate-specific split
- `SizeQuerySpec` / `AbstractHibernateCriterionAdapter` — backport to
`7.0.x` as separate PR
- `grails-datamapping-core/GroovyProxyFactory.groovy` — Scott's PR dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
