borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3440101854
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/CustomAutoTimestampSpec.groovy:
##########
@@ -27,9 +30,12 @@ import
org.grails.datastore.gorm.events.AutoTimestampEventListener
class CustomAutoTimestampSpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
void setupSpec() {
- manager.domainClasses.addAll([AutoTimestampedChildEntity,
AutoTimestampedParentEntity, Image, RecordCustom, RecordWithAliases])
+ manager.addAllDomainClasses([AutoTimestampedChildEntity,
AutoTimestampedParentEntity, Image, RecordCustom, RecordWithAliases])
}
+ @Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/AsyncReadMethodsSpec.groovy:
##########
@@ -28,6 +28,7 @@ import
org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
*/
class AsyncReadMethodsSpec extends GrailsDataTckSpec<GrailsDataCoreTckManager>
{
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/AsyncReadMethodsSpec.groovy:
##########
@@ -48,6 +49,7 @@ class AsyncReadMethodsSpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
results[2].firstName == "Barney"
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/AsyncReadMethodsSpec.groovy:
##########
@@ -69,6 +71,7 @@ class AsyncReadMethodsSpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/AsyncReadMethodsSpec.groovy:
##########
@@ -98,6 +101,7 @@ class AsyncReadMethodsSpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
results[2].firstName == "Barney"
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
The `@Requires` annotations were reverted in a prior cleanup commit — these
specs now run without restrictions across all GORM implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
