borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3470036887
##########
grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/validation/CascadeValidationSpec.groovy:
##########
@@ -35,7 +35,7 @@ class CascadeValidationSpec extends Specification {
@Shared @AutoCleanup HibernateDatastore hibernateDatastore = new
HibernateDatastore(Business, Person, Employee)
@Rollback
- @Issue('https://github.com/apache/grails-data-mapping/issues/926')
+ @Issue('https://github.com/grails/grails-data-mapping/issues/926')
Review Comment:
The `nullable: false` constraint on `Business.name` was added because commit
`c27b930c00` ("nullable by default") made unconstrained properties nullable.
Without the explicit constraint the test would pass even with an invalid empty
name, breaking its cascade-validation assertion.
##########
grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/SubclassMultipleListCollectionSpec.groovy:
##########
@@ -27,7 +27,7 @@ import spock.lang.*
/**
* Created by graemerocher on 01/03/2017.
*/
-@Ignore
+@Ignore // https://github.com/apache/grails-core/issues/14624 —
MappingException: Repeated column (iteration_id) for Product; not fixed in this
PR
Review Comment:
Done in `6505db22bb` — class-level
`@Issue('https://github.com/apache/grails-core/issues/14624')` added alongside
`@Ignore`; the redundant method-level `@Ignore // not yet implemented` and the
stale `grails-data-mapping/issues/882` ref removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
