borinquenkid commented on code in PR #15568: URL: https://github.com/apache/grails-core/pull/15568#discussion_r3470042990
########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ClassPropertiesBinder.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; + +import org.hibernate.MappingException; +import org.hibernate.mapping.PersistentClass; +import org.hibernate.mapping.Table; +import org.hibernate.mapping.Value; + +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentEntity; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentProperty; +import org.grails.orm.hibernate.cfg.domainbinding.util.PropertyFromValueCreator; + +/** + * Binds the properties of a Grails domain class to the Hibernate meta-model. + * + * @author Graeme Rocher + * @since 7.0 + */ +@SuppressWarnings("PMD.DataflowAnomalyAnalysis") +public class ClassPropertiesBinder { + + private final GrailsPropertyBinder grailsPropertyBinder; + private final PropertyFromValueCreator propertyFromValueCreator; + private final NaturalIdentifierBinder naturalIdentifierBinder; + + /** Creates a new {@link ClassPropertiesBinder} instance. */ Review Comment: Removed in `ad5114dfab`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ClassPropertiesBinder.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; + +import org.hibernate.MappingException; +import org.hibernate.mapping.PersistentClass; +import org.hibernate.mapping.Table; +import org.hibernate.mapping.Value; + +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentEntity; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentProperty; +import org.grails.orm.hibernate.cfg.domainbinding.util.PropertyFromValueCreator; + +/** + * Binds the properties of a Grails domain class to the Hibernate meta-model. + * + * @author Graeme Rocher + * @since 7.0 Review Comment: Fixed in `ad5114dfab` — changed from `@since 7.0` to `@since 8.0`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ClassPropertiesBinder.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; + +import org.hibernate.MappingException; +import org.hibernate.mapping.PersistentClass; +import org.hibernate.mapping.Table; +import org.hibernate.mapping.Value; + +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentEntity; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentProperty; +import org.grails.orm.hibernate.cfg.domainbinding.util.PropertyFromValueCreator; + +/** + * Binds the properties of a Grails domain class to the Hibernate meta-model. + * + * @author Graeme Rocher + * @since 7.0 + */ +@SuppressWarnings("PMD.DataflowAnomalyAnalysis") +public class ClassPropertiesBinder { + + private final GrailsPropertyBinder grailsPropertyBinder; + private final PropertyFromValueCreator propertyFromValueCreator; + private final NaturalIdentifierBinder naturalIdentifierBinder; + + /** Creates a new {@link ClassPropertiesBinder} instance. */ + public ClassPropertiesBinder( + GrailsPropertyBinder grailsPropertyBinder, + PropertyFromValueCreator propertyFromValueCreator, + NaturalIdentifierBinder naturalIdentifierBinder) { + this.grailsPropertyBinder = grailsPropertyBinder; + this.propertyFromValueCreator = propertyFromValueCreator; + this.naturalIdentifierBinder = naturalIdentifierBinder; + } + + /** Creates a new {@link ClassPropertiesBinder} instance. */ Review Comment: Removed in `ad5114dfab`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ClassBinder.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; + +import org.hibernate.boot.spi.InFlightMetadataCollector; +import org.hibernate.mapping.PersistentClass; + +import org.grails.orm.hibernate.cfg.Mapping; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.GrailsHibernatePersistentEntity; + +import static org.grails.orm.hibernate.cfg.GrailsHibernateUtil.unqualify; + +/** The class binder class. */ +public class ClassBinder { + + private final InFlightMetadataCollector collector; + + public ClassBinder(@Nonnull InFlightMetadataCollector collector) { + this.collector = collector; + } + + /** + * Binds the specified persistant class to the runtime model based on the properties defined in + * the domain class + * + * @param persistentEntity The Grails domain class + * @param persistentClass The persistant class + */ Review Comment: Fixed in `ad5114dfab` — corrected to `persistent` (twice in the Javadoc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
