borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3470037953
##########
grails-data-hibernate5/core/src/test/groovy/org/grails/datastore/mapping/model/PersistentPropertySpec.groovy:
##########
@@ -21,9 +21,6 @@ package org.grails.datastore.mapping.model
import grails.gorm.tests.HibernateGormDatastoreSpec
import grails.persistence.Entity
-import spock.lang.Issue
-
-@Issue('https://github.com/apache/grails-data-mapping/issues/1299')
Review Comment:
Done in `6505db22bb` — blank line added in both H5 and H7.
##########
grails-data-hibernate7/grails-plugin/src/main/groovy/grails/test/hibernate/HibernateSpec.groovy:
##########
@@ -58,14 +58,15 @@ import org.hibernate.boot.registry.BootstrapServiceRegistry
import org.hibernate.boot.registry.StandardServiceRegistryBuilder
import org.hibernate.dialect.H2Dialect
import org.grails.orm.hibernate.proxy.GrailsBytecodeProvider
-import org.hibernate.proxy.pojo.bytebuddy.ByteBuddyProxyHelper
import org.hibernate.internal.SessionFactoryImpl
import org.hibernate.service.spi.ServiceRegistryImplementor
import org.springframework.context.ApplicationContext
/**
* Specification for Hibernate tests
*
+ * TODO: rename to AHibernateSpec to follow the abstract class naming
convention
+ *
Review Comment:
Agreed — TODO removed in `6505db22bb`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
