codeconsole commented on PR #16292:
URL: https://github.com/apache/grails-core/pull/16292#issuecomment-5608910530
Both items addressed in three commits, with per-finding replies inline.
- `67d20dc` — `inner.setEnclosingMethod(liftedMethod)` in the re-homing
loop, alongside the `this$0` field, constructor parameter and call argument it
already corrects. Covers the `@CompileStatic` descriptor with an anonymous
class in a top-level bean body and every `group(...)` body that constructs one,
on both host kinds.
- `191830e` — the anonymous-class reach check now runs per group as well as
per sibling, with the early return moved to the sibling call site. A group
passes no moved set: it is a static nested class with no enclosing instance, so
anything the class cannot resolve on itself or what it inherits is rejected.
- `635f284` — a `DynamicVariable` matches on the `get`/`is`/`set` spellings
of its name as well as its own, so `method('getSuffix', String)` plus `suffix`
is caught.
12 tests added (325 in the module spec), each confirmed to fail with its fix
backed out. Also green: `checkstyleMain`, `compileGroovy` on all eight in-tree
`beans = { }` users, and both `beans-dsl` example projects.
On CI: the two reds are `EndToEndSpec > async multiple levels of layouts`
and `UserControllerSpec > User list`, both listed on #16030 against `8.0.x`
itself at 2% and 3%. This round touched only `grails-beans-dsl` and
`grails-doc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
