matrei opened a new pull request, #39:
URL: https://github.com/apache/grails-gradle-publish/pull/39
Upgrades the build to Gradle 9.8.0 and fixes every deprecation warning it
reports, both in this build and in the functional test builds, so the plugin is
ready for Gradle 10.
## Changes
**Plugin**
- `GrailsPublishGradlePlugin`: replaces `sourceSets.findAll { … }` with
`sourceSets.matching { … }`. `DomainObjectCollection.findAll(Closure)` is
deprecated and will be removed in Gradle 10, so without this change the plugin
would break for consumers on Gradle 10. Behavior is unchanged.
**Build**
- Gradle wrapper and `.sdkmanrc` bumped to 9.8.0 (wrapper regenerated via
`gradle-bootstrap`).
- `gradle/publish-config.gradle`, `gradle/signing-config.gradle`: reference
`rootProject.isReleaseVersion` explicitly instead of relying on the deprecated
implicit lookup of properties in parent projects.
**Functional tests**
- Use assignment syntax (`url = …`, `version = …`, `group = …`) instead of
the deprecated space-assignment syntax in the test build scripts and the inline
scripts in `GrailsPublishPluginSpec`.
- Pass `System.getenv('LOCAL_MAVEN_PATH')` directly instead of wrapping it
in a GString. If the variable is ever unset, the build now fails with "You must
specify a URL for a Maven repository." Before, it silently pointed the
repository at `<projectDir>/null`.
## Verification
- `./gradlew clean check --rerun-tasks --warning-mode=all` on Gradle 9.8.0:
unit tests 12/12 passed, functional tests 44 run with 0 failures and 6 skipped.
- No deprecation warnings left, including in the nested TestKit builds. To
check them, `--warning-mode=all` was temporarily added to the TestKit
arguments; that change is not part of this PR.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
