matrei commented on PR #39: URL: https://github.com/apache/grails-gradle-publish/pull/39#issuecomment-5854718118
@jdaugherty, since my last comment I tested the branch against grails-core and ran another review pass, which led to seven more commits: - **grails-core extends the plugin.** `GrailsProfilePublishGradlePlugin` subclasses `GrailsPublishGradlePlugin` with its own injected constructor, which no longer compiled once `BuildFeatures` was injected through the constructor. 1374d81 injects it through a getter instead, with a test using a subclass shaped like grails-core's. - **Signatures were written into the classes directory.** The extra artifact (`grails-plugin.xml`, or `profile.yml` for profiles) was published straight from the classes directory, so its signature landed there. The old `Sign` → every `Jar` dependency had been hiding that; without it, publishing grails-core failed in `grails-undertow`. 2dd9256 publishes a copy from `build/grails-publish/extra-artifact`. - **Gradle plugin projects:** the `addComponents = false` default from e6f4a7c also dropped test sources, version mapping and additional publications. 5e78370 only leaves the `java` component to `java-gradle-plugin`, only reuses `pluginMaven`, and makes additional publications fail with an explanation in that setup. - **Directory check:** it read the component's variants in `afterEvaluate`, which locked the component against later changes. d2f482b runs it when the task graph is ready. - **Smaller fixes:** precise wording for which `gradle.properties` files are read (71583c3), the remaining redundant jar inputs (ec59881), and `ReleaseSigningSpec` now verifies each signature with gpg (b15e19c). With the final state, a release run of grails-core, grails-forge and grails-gradle (following codeconsole's approach in apache/grails-core#16403) matches a run with `1.0.x`. The same 5,058 files are published, all 843 signatures verify, and 841 of 843 artifacts are byte-identical. The only difference is `grails-gradle-plugins-8.0.0.jar`, whose SBOM records the `grails-publish` jar it was built with. The details are in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
