matrei commented on PR #39: URL: https://github.com/apache/grails-gradle-publish/pull/39#issuecomment-5844908054
@jdaugherty, a correction to my earlier comment, plus some additions since your review: - **Parent-project properties:** I said `ext` values from a parent build script keep working. That's no longer the case. Walking the parents explicitly avoids the Gradle 10 removal, but it isn't allowed with Isolated Projects, and since 1.0.0 isn't final yet, c6f6e05 drops the parent lookup instead of carrying it through all of 1.x. Because a publish type set on a parent would otherwise be ignored silently, that case now fails the build with a message saying where to set it. The README documents the lookup rules. - **The gradle/gradle#26091 workaround:** I tested it with signed releases. The `Sign` → every `Jar` dependency wasn't needed, and the ordering didn't cover `PublishToMavenLocal`. In this plugin the shared artifacts came from Gradle plugin projects publishing their jars through both `pluginMaven` and our `maven` publication. e6f4a7c makes those projects use `pluginMaven` (as grails-core already does by hand), and 27ba06c replaces the workaround with an ordering for all publish tasks. - **Signed releases with additional publications failed:** the example project's component included the class and resource directory variants. 0277710 fixes the example and the README, and makes the plugin fail early with an explanation. - **Signing test:** `ReleaseSigningSpec` (49232ab) signs releases with a throwaway GPG key, so this wiring is covered from now on. The PR description lists the two breaking changes for the release notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
