matrei commented on PR #39: URL: https://github.com/apache/grails-gradle-publish/pull/39#issuecomment-5834915582
Thanks for the thorough review, @jdaugherty. I addressed everything in this PR, one commit per point: - **`org.gradle.tooling.parallel`**: set explicitly in 25101cf. - **Parent-project property lookups**: fc202d8 adds a `findProjectProperty` helper that checks the project's extra properties and then those of its ancestors. `-P`, `ORG_GRADLE_PROJECT_*` and `gradle.properties` values are set on every project, so they're still found on the project itself, and `ext` values from a parent build script keep working. There's a new functional test for that (`githubSlug` and `mavenPublishUrl` set via `ext` in the root project). One caveat: Gradle 9.8 doesn't warn about these calls, so the old code also passes the test. It guards behaviour for Gradle 10, which I couldn't run. I also removed the "ready for Gradle 10" wording from the description. - **`testSourcesJar` and the configuration cache**: fixed in e3ab538 by capturing the `publishTestSources` provider at configuration time. The existing configuration-cache test runs `assemble`, which doesn't include `testSourcesJar`, so I added a fixture with test sources published. The new test fails without the fix with the `DefaultProject` serialization error, as you predicted. - **`--warning-mode=fail`**: added to `GradleSpecification.executeTask` in 5017269. - **Commented-out `findAll`**: switched to `matching` in e3a611f. `./gradlew clean check` passes on 9.8.0 with no deprecation warnings: 46 functional tests with 0 failures and 6 skipped, and 12/12 unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
