rpuch commented on code in PR #3378:
URL: https://github.com/apache/ignite-3/pull/3378#discussion_r1517635612
##########
modules/core/src/main/java/org/apache/ignite/internal/lang/IgniteExceptionMapperUtil.java:
##########
@@ -126,6 +127,11 @@ public static Throwable mapToPublicException(Throwable
origin) {
* @return New CompletableFuture.
*/
public static <T> CompletableFuture<T>
convertToPublicFuture(CompletableFuture<T> origin) {
+ if (isCompletedSuccessfully(origin)) {
+ // No need to translate exceptions.
Review Comment:
Agreed. Let's do it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
