rpuch commented on code in PR #3378:
URL: https://github.com/apache/ignite-3/pull/3378#discussion_r1517664447
##########
modules/core/src/main/java/org/apache/ignite/internal/util/CompletableFutures.java:
##########
@@ -132,4 +132,19 @@ public static <T> CompletableFuture<T>
completedOrFailedFuture(@Nullable T resul
return completedFuture(result);
}
}
+
+ /**
+ * Completes a future either with an exception (if it's not {@code null}
or normally.
+ *
+ * @param future Future to complete.
+ * @param result Normal completion result. Only used if the exception is
{@code null}.
+ * @param ex Exception. If not {@code null}, the future will be failed
with it, otherwise it will be completed normally.
+ */
+ public static <T> void completeOrFailFuture(CompletableFuture<T> future,
@Nullable T result, @Nullable Throwable ex) {
Review Comment:
After another change this method became unnecessary, so I removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
