rpuch commented on code in PR #3378:
URL: https://github.com/apache/ignite-3/pull/3378#discussion_r1517642175
##########
modules/table/src/main/java/org/apache/ignite/internal/table/AbstractTableView.java:
##########
@@ -99,19 +115,40 @@ abstract class AbstractTableView<R> implements
CriteriaQuerySource<R> {
* @param <T> Future result type.
* @return Future result.
*/
- protected final <T> T sync(CompletableFuture<T> fut) {
+ protected final <T> T sync(Supplier<CompletableFuture<T>> fut) {
+ // Enclose in 'internal call' to prevent resubmission to the async
continuation pool on future completion
+ // as such a resubmission is useless in the sync case and will just
increase latency.
+ PublicApiThreading.startInternalCall();
Review Comment:
I wanted to save an allocation of yet another lambda. Also, I would have to
put that big try/catch block inside of it, which would look pretty ugly (no pun
intented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
