rpuch commented on code in PR #3378:
URL: https://github.com/apache/ignite-3/pull/3378#discussion_r1517636515
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -566,7 +567,17 @@ private void processOperation(ChannelHandlerContext ctx,
ClientMessageUnpacker i
// Observable timestamp should be calculated after the operation
is processed; reserve space, write later.
int observableTimestampIdx = out.reserveLong();
- CompletableFuture fut = processOperation(in, out, opCode,
requestId);
+ CompletableFuture fut;
+
+ // Enclosing in 'internal call' to save resubmission to the async
continuation thread pool on return. This will only
+ // work if the corresponding call (like an async KeyValueView
method) is invoked in this same thread, but in most cases this
+ // will be true.
+ PublicApiThreading.startInternalCall();
Review Comment:
`processOperation()` throws a checked exception. Also, I wanted to save an
allocation (on a lambda)
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -566,7 +567,17 @@ private void processOperation(ChannelHandlerContext ctx,
ClientMessageUnpacker i
// Observable timestamp should be calculated after the operation
is processed; reserve space, write later.
int observableTimestampIdx = out.reserveLong();
- CompletableFuture fut = processOperation(in, out, opCode,
requestId);
+ CompletableFuture fut;
+
+ // Enclosing in 'internal call' to save resubmission to the async
continuation thread pool on return. This will only
+ // work if the corresponding call (like an async KeyValueView
method) is invoked in this same thread, but in most cases this
+ // will be true.
+ PublicApiThreading.startInternalCall();
Review Comment:
`processOperation()` throws a checked exception. Also, I wanted to save an
allocation (a lambda)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
