mbien commented on PR #8276: URL: https://github.com/apache/netbeans/pull/8276#issuecomment-2693282901
@neilcsmith-net I would like to apologize for what i wrote in the last post. It reads a bit harsh. What I meant was that by removing the max-lifetime aspect (which is very common for cursor changes, most OS launchers do this for example) we can switch to a much simpler implementation (~36 loc). The second point was that due to the nature of having to decouple from the thread (EDT or not) in the enable() method due to the delay, the first method already is thread safe by nature. Making disable() also thread safe is just a nice-to-have without added complexity. That is why I would like to make this whole class thread safe - this also simplifies the client contract. (I also shouldn't have posted the snippet in https://github.com/apache/netbeans/pull/8276#issuecomment-2681930534 since it contained too much stuff from the original RP based version still) Maybe one day we can cherry pick some of the reusable utilities and put it into a shared UI module - I think this could be a candidate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
