mbien commented on PR #8276: URL: https://github.com/apache/netbeans/pull/8276#issuecomment-2694868380
> I still don't particularly like your current implementation - I preferred your original https://github.com/apache/netbeans/commit/e05c95669deb8ae643ba019fa710c4b379cadf27 that one? I can still revert it, it already was approved+tested which speeds things up. > The implementation might be thread safe, but I'm not aware that Timer methods are documented to be thread safe? all queue methods are under a reentrant lock, the internal queue is accessed under a class lock. The doc does also not mention that it is not thread safe ;) > I prefer trying to keep concurrent code isolated and together, rather than sprinkled around I don't understand this argument since everything is in one utility class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
