neilcsmith-net commented on PR #8276: URL: https://github.com/apache/netbeans/pull/8276#issuecomment-2695041146
> [e05c956](https://github.com/apache/netbeans/commit/e05c95669deb8ae643ba019fa710c4b379cadf27) that one? I can still revert it, it already was approved+tested which speeds things up. Yes. I did say that this would be simpler _if_ you moved all the scheduling code on to the EDT and used a Timer. If you want to keep controlling it off of the EDT, then stick with what you had. > The doc does also not mention that it is not thread safe ;) It's Swing! :wink: Everything that is meant to be thread safe is stated to be documented as such. I checked the implementation already. > > I prefer trying to keep concurrent code isolated and together, rather than sprinkled around > > I don't understand this argument since everything is in one utility class. I have a preference to inside one method / call approach when it can be, that's all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
